Fix: dont crash on startup if funds migration fails #4827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkmc
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
|
I can confirm it fixes #4823 |
hannahhoward
approved these changes
Nov 12, 2020
magik6k
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't crash on startup if funds migration fails.
I'm not 100% sure this is what we want to do. It may cause some in-progress deals to fail, but is probably better than crashing.
Edit: The correct solution here is probably for the migration to subtract the amount of completed / failed deals from the reserved amount